Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENG-9847: Add service_configs field to sidecar resource #437

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

ENG-9847: Add service_configs field to sidecar resource #437

wants to merge 4 commits into from

Conversation

VictorGFM
Copy link
Contributor

@VictorGFM VictorGFM commented Aug 11, 2023 •
edited
Loading

Description of the change

ENG-9847: Support configuring sidecar log levels from Terraform

This PR addresses the following:

  • Adds service_configs field to sidecar resource (This field is used for setting specific sidecar services configurations).
  • Bumps module dependencies to solve dependabot PRs.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • Jira issue referenced in commit message and/or PR title

Testing

On progress...

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cyral-bot cyral-bot Awaiting requested review from cyral-bot cyral-bot will be requested when the pull request is marked ready for review cyral-bot is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@VictorGFM